add a global project config #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 581f231 in 30 seconds
More details
- Looked at
199lines of code in8files - Skipped
0files when reviewing. - Skipped posting
6drafted comments based on config settings.
1. py/core/base/logging/run_logger.py:347
- Draft comment:
Consider retaining the fallback toos.getenv("R2R_PROJECT_NAME", "default")for backward compatibility in caseconfig.app.project_nameis not set. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The code change already includes a fallback mechanism usingos.getenv("R2R_PROJECT_NAME", "default")ifconfig.app.project_nameis not set. The comment seems to suggest something that is already implemented in the code. Therefore, the comment is redundant and does not require any further action.
I might be missing some context about why the comment was made, but based on the code change, it seems the fallback is already implemented. The comment might have been made before the code was updated to include the fallback.
The code clearly shows the fallback mechanism is in place, so the comment is unnecessary. The comment might have been made based on an outdated version of the code.
The comment is redundant because the code already includes the suggested fallback mechanism. Therefore, the comment should be deleted.
2. py/core/base/logging/run_logger.py:586
- Draft comment:
Theconfiguremethod no longer has a defaultLoggingConfig. Ensure this change is documented as it requires explicit configuration now. - Reason this comment was not posted:
Confidence changes required:50%
Theconfiguremethod inRunLoggingSingletonwas changed to remove the defaultLoggingConfigargument. This is a good change as it enforces explicit configuration, but it should be documented in the method docstring or comments.
3. py/core/base/providers/base.py:21
- Draft comment:
The addition ofapp: AppConfigtoProviderConfigis consistent with the new global project config approach. Ensure all providers are updated to handle this new field. - Reason this comment was not posted:
Confidence changes required:30%
The addition ofAppConfigto theProviderConfigclass inbase.pyis consistent with the new global project config approach. This change is correctly reflected in theR2RConfigclass inconfig.py.
4. py/core/base/providers/base.py:9
- Draft comment:
Ensure thatAppConfigincludes all necessary fields for global app settings and that these fields are well-documented. - Reason this comment was not posted:
Confidence changes required:40%
TheAppConfigclass is introduced to handle global app settings, which is a good addition. However, ensure that all necessary fields are included and documented.
5. py/core/main/config.py:124
- Draft comment:
The integration ofAppConfigintoR2RConfigis well-implemented. Ensure that all sections that requireappare updated accordingly. - Reason this comment was not posted:
Confidence changes required:30%
TheAppConfigis correctly integrated into theR2RConfigclass, and thecreatemethod is used to instantiate it. This ensures consistency across the configuration setup.
6. py/core/providers/database/postgres.py:75
- Draft comment:
Consider retaining the fallback toos.getenv("R2R_PROJECT_NAME")for backward compatibility in caseconfig.app.project_nameis not set. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_9QU0EipGcsJgER7e
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
emrgnt-cmplxty
added a commit
that referenced
this pull request
Oct 4, 2024
* fix issues in compose (#1324) * Update Hatchet compose setup (#1327) * add ingest chunks workflows (#1329) * add ingest chunks workflows * finalize ingest chunks * fix * Allow for exclusion of postgres (#1328) * update type checks (#1331) * Limiting KG Creation Scheduling (#1332) * try * up * up * space * add it in ingestion * rm ingestion * up * bump pkg * add a global project config (#1333) * Corrections for KG SDK usage (#1330) * Corrections for KG SDK usage * Clean up * missed file * Adding a completions endpoint (#1326) * up * rm unnecessary import * add completion model * up * Update JS (#1335) --------- Co-authored-by: Nolan Tremelling <[email protected]> Co-authored-by: Shreyas Pimpalgaonkar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds a global project configuration using
AppConfigfor centralized project settings across logging, database, and configuration modules.AppConfigclass inbase.pyfor global project settings.R2RConfiginconfig.pyto includeapp: AppConfig.[app]section inr2r.tomlfor project-wide settings.PostgresRunLoggingProviderinrun_logger.pyto useconfig.app.project_name.configure()method inRunLoggingSingletonto requireLoggingConfig.PostgresDBProviderinpostgres.pyto useconfig.app.project_name.app: AppConfigfield toProviderConfiginbase.py.AppConfigin__init__.pyfor providers.This description was created by
for 581f231. It will automatically update as commits are pushed.